From 1f912a0f58a04ff8a38f47349f31532b6c792848 Mon Sep 17 00:00:00 2001 From: Dorian Date: Wed, 22 Apr 2026 09:18:49 -0400 Subject: [PATCH] fix(catalog): prefix bitcoin-core image with docker.io/ so the install validator accepts it The trusted-registry allowlist in api/rpc/package/config.rs splits the image on '/' and matches the first segment against a fixed set (docker.io, ghcr.io, git.tx1138.com, 23.182.128.160:3000, ghcr.io, localhost). A bare 'bitcoin/bitcoin:28.4' splits to registry="bitcoin" which isn't on the list, so the install RPC was returning 'Invalid Docker image format'. Live catalogs on .160 and gitea-local already hotfixed directly; these static copies keep ISO builds and the final hardcoded fallback in sync. Co-Authored-By: Claude Opus 4.7 (1M context) --- app-catalog/catalog.json | 2 +- neode-ui/public/catalog.json | 2 +- neode-ui/src/views/discover/curatedApps.ts | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/app-catalog/catalog.json b/app-catalog/catalog.json index f9e2caa8..542e45c7 100644 --- a/app-catalog/catalog.json +++ b/app-catalog/catalog.json @@ -23,7 +23,7 @@ "description": "Reference implementation of the Bitcoin protocol. Run a full node validating and relaying blocks.", "icon": "/assets/img/app-icons/bitcoin-core.svg", "author": "Bitcoin Core contributors", "category": "money", "tier": "optional", - "dockerImage": "bitcoin/bitcoin:28.4", + "dockerImage": "docker.io/bitcoin/bitcoin:28.4", "repoUrl": "https://github.com/bitcoin/bitcoin" }, { diff --git a/neode-ui/public/catalog.json b/neode-ui/public/catalog.json index 06fe281b..16d2ff19 100644 --- a/neode-ui/public/catalog.json +++ b/neode-ui/public/catalog.json @@ -29,7 +29,7 @@ "description": "Reference implementation of the Bitcoin protocol. Run a full node validating and relaying blocks on the Bitcoin network.", "icon": "/assets/img/app-icons/bitcoin-core.svg", "author": "Bitcoin Core contributors", - "dockerImage": "bitcoin/bitcoin:28.4", + "dockerImage": "docker.io/bitcoin/bitcoin:28.4", "repoUrl": "https://github.com/bitcoin/bitcoin", "category": "money", "tier": "optional" diff --git a/neode-ui/src/views/discover/curatedApps.ts b/neode-ui/src/views/discover/curatedApps.ts index 539ea621..389db133 100644 --- a/neode-ui/src/views/discover/curatedApps.ts +++ b/neode-ui/src/views/discover/curatedApps.ts @@ -77,7 +77,7 @@ export async function fetchAppCatalog(): Promise { export function getCuratedAppList(): MarketplaceApp[] { return [ { id: 'bitcoin-knots', title: 'Bitcoin Knots', version: '28.1.0', description: 'Run a full Bitcoin node. Validate and relay blocks and transactions on the Bitcoin network.', icon: '/assets/img/app-icons/bitcoin-knots.webp', author: 'Bitcoin Knots', dockerImage: `${R}/bitcoin-knots:latest`, repoUrl: 'https://github.com/bitcoinknots/bitcoin' }, - { id: 'bitcoin-core', title: 'Bitcoin Core', version: '28.4', description: 'Reference implementation of the Bitcoin protocol. Run a full node validating and relaying blocks on the Bitcoin network.', icon: '/assets/img/app-icons/bitcoin-core.svg', author: 'Bitcoin Core contributors', dockerImage: 'bitcoin/bitcoin:28.4', repoUrl: 'https://github.com/bitcoin/bitcoin' }, + { id: 'bitcoin-core', title: 'Bitcoin Core', version: '28.4', description: 'Reference implementation of the Bitcoin protocol. Run a full node validating and relaying blocks on the Bitcoin network.', icon: '/assets/img/app-icons/bitcoin-core.svg', author: 'Bitcoin Core contributors', dockerImage: 'docker.io/bitcoin/bitcoin:28.4', repoUrl: 'https://github.com/bitcoin/bitcoin' }, { id: 'btcpay-server', title: 'BTCPay Server', version: '1.13.7', description: 'Self-hosted Bitcoin payment processor. Accept Bitcoin payments without intermediaries or fees.', icon: '/assets/img/app-icons/btcpay-server.png', author: 'BTCPay Server Foundation', dockerImage: `${R}/btcpayserver:1.13.7`, repoUrl: 'https://github.com/btcpayserver/btcpayserver' }, { id: 'lnd', title: 'LND', version: '0.18.4', description: 'Lightning Network Daemon. Fast and cheap Bitcoin payments through the Lightning Network.', icon: '/assets/img/app-icons/lnd.svg', author: 'Lightning Labs', dockerImage: `${R}/lnd:v0.18.4-beta`, repoUrl: 'https://github.com/lightningnetwork/lnd' }, { id: 'mempool', title: 'Mempool Explorer', version: '3.0.0', description: 'Self-hosted Bitcoin blockchain and mempool visualizer. Monitor transactions without revealing your addresses to third parties.', icon: '/assets/img/app-icons/mempool.webp', author: 'Mempool', dockerImage: `${R}/mempool-frontend:v3.0.0`, repoUrl: 'https://github.com/mempool/mempool' },