test(lifecycle): immich suite — package-level checks, wait-based destructive tier

container-list reports stack apps package-level (.name="immich"), so the suite
checks the "immich" package (presence, valid state, :2283 lan-address) rather than
individual container names. Destructive tier fires async stop/start/restart and
asserts on the end state via wait_for_container_status.

KNOWN: the destructive tier is flaky for slow multi-container stacks — bats runs
ops back-to-back with no settling while immich's async stack ops take 30s+, and
stopped reports as "exited" not "stopped". The immich migration itself is verified
working (manual stop/start/restart succeed; all 3 containers healthy). Hardening
the harness for stack apps (inter-op settling + stopped|exited acceptance) is a
follow-up.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

tests/lifecycle/bats/immich.bats

@@ -1,17 +1,17 @@
 #!/usr/bin/env bats
 # tests/lifecycle/bats/immich.bats
 #
-# Lifecycle tests for the immich stack (manifest-driven: immich + immich-postgres
+# Lifecycle tests for the manifest-driven immich stack. The user-facing package is
-# + immich-redis, installed via the orchestrator — NOT the legacy install_immich_stack).
+# "immich" (catalog title + icon); container-list reports it package-level as
+# "immich". Its containers are named immich_server / immich_postgres /
+# immich_redis (underscore) to match the runtime's per-app lifecycle references.
 #
 # Tiers:
-#   - Read-only (always):                      presence + valid state of all 3 members
+#   - Read-only (always):                      presence + valid state
-#   - Destructive (ARCHY_ALLOW_DESTRUCTIVE=1): stop → start → restart the server
+#   - Destructive (ARCHY_ALLOW_DESTRUCTIVE=1): stop → start → restart
-#   - Cascade (ARCHY_ALLOW_CASCADE_DESTRUCTIVE=1): uninstall → reinstall the stack
+#   - Cascade (ARCHY_ALLOW_CASCADE_DESTRUCTIVE=1): uninstall → reinstall (preserve_data)
-#     (preserve_data so the photo library + DB survive)
 #
-# All checks are RPC-based so the suite is correct whether run on the host or
+# RPC-based, so correct whether run on the host or against a remote ARCHY_HOST.
-# against a remote ARCHY_HOST.
 
 load '../lib/rpc.bash'
 
@@ -28,58 +28,49 @@ teardown_file() {
   rpc_logout_local
 }
 
-container_state() {
-  rpc_result container-list | jq -r --arg n "$1" '.[] | select(.name == $n) | .state'
-}
-
 # ────────────────────────────────────────────────────────────────────
 # Read-only tier
 # ────────────────────────────────────────────────────────────────────
 
-@test "container-list includes the immich stack members" {
+@test "container-list includes immich" {
   run rpc_result container-list
   [ "$status" -eq 0 ]
   echo "$output" | jq -e '.[] | select(.name == "immich")' >/dev/null
-  echo "$output" | jq -e '.[] | select(.name == "immich-postgres")' >/dev/null
-  echo "$output" | jq -e '.[] | select(.name == "immich-redis")' >/dev/null
 }
 
-@test "immich stack members report valid states" {
+@test "container-list reports a valid state for immich" {
-  for c in immich immich-postgres immich-redis; do
-    local state
-    state=$(container_state "$c")
-    [[ "$state" =~ ^(running|stopped|exited|created|paused)$ ]] || {
-      echo "unexpected state for $c: $state"; return 1
-    }
-  done
-}
-
-@test "no legacy underscore immich containers (immich_postgres/_redis/_server)" {
-  # The legacy install_immich_stack named members with underscores. The
-  # manifest-driven stack uses hyphenated app_id names. Underscore containers
-  # mean a botched migration (or a fallback to the legacy installer).
   run rpc_result container-list
   [ "$status" -eq 0 ]
-  echo "$output" | jq -e '[.[] | select(.name | test("^immich_"))] | length == 0' >/dev/null
+  local state
+  state=$(echo "$output" | jq -r '.[] | select(.name == "immich") | .state')
+  [[ "$state" =~ ^(running|stopped|exited|created|paused)$ ]]
+}
+
+@test "immich exposes its web UI lan-address (port 2283)" {
+  run rpc_result container-list
+  [ "$status" -eq 0 ]
+  echo "$output" | jq -e '.[] | select(.name == "immich") | .lan_address | test("2283")' >/dev/null
 }
 
 # ────────────────────────────────────────────────────────────────────
-# Destructive tier (stop → start → restart the server)
+# Destructive tier (stop → start → restart)
 # ────────────────────────────────────────────────────────────────────
 
 @test "package.stop transitions immich to stopped" {
   [[ "${ARCHY_ALLOW_DESTRUCTIVE:-0}" == "1" ]] || skip "ARCHY_ALLOW_DESTRUCTIVE not set"
-  run rpc_result package.stop '{"id":"immich"}'
+  # package.stop is async ({"status":"stopping"}) and a stack stop can race a
-  [ "$status" -eq 0 ]
+  # still-settling prior op, so the end state — not the immediate RPC return — is
-  run wait_for_container_status immich stopped 60
+  # the assertion.
+  rpc_call package.stop '{"id":"immich"}' >/dev/null 2>&1 || true
+  run wait_for_container_status immich stopped 90
   [ "$status" -eq 0 ]
 }
 
 @test "package.start brings immich back to running" {
   [[ "${ARCHY_ALLOW_DESTRUCTIVE:-0}" == "1" ]] || skip "ARCHY_ALLOW_DESTRUCTIVE not set"
-  run rpc_result package.start '{"id":"immich"}'
+  # Async start; the server comes up only after postgres is ready (~30s+), so wait.
-  [ "$status" -eq 0 ]
+  rpc_call package.start '{"id":"immich"}' >/dev/null 2>&1 || true
-  run wait_for_container_status immich running 120
+  run wait_for_container_status immich running 180
   [ "$status" -eq 0 ]
 }
 
@@ -91,17 +82,11 @@ container_state() {
   [ "$status" -eq 0 ]
 }
 
-@test "postgres + redis stay running across an immich server restart" {
-  [[ "${ARCHY_ALLOW_DESTRUCTIVE:-0}" == "1" ]] || skip "ARCHY_ALLOW_DESTRUCTIVE not set"
-  [ "$(container_state immich-postgres)" == "running" ]
-  [ "$(container_state immich-redis)" == "running" ]
-}
-
 # ────────────────────────────────────────────────────────────────────
 # Cascade tier (uninstall + reinstall the stack)
 # ────────────────────────────────────────────────────────────────────
 
-@test "package.uninstall removes the immich stack (data preserved)" {
+@test "package.uninstall removes immich (data preserved)" {
   [[ "${ARCHY_ALLOW_CASCADE_DESTRUCTIVE:-0}" == "1" ]] || skip "ARCHY_ALLOW_CASCADE_DESTRUCTIVE not set"
   run rpc_result package.uninstall '{"id":"immich","preserve_data":true}'
   [ "$status" -eq 0 ]
@@ -109,14 +94,10 @@ container_state() {
   [ "$status" -eq 0 ]
 }
 
-@test "package.install immich brings the whole stack back to running" {
+@test "package.install immich returns to running" {
   [[ "${ARCHY_ALLOW_CASCADE_DESTRUCTIVE:-0}" == "1" ]] || skip "ARCHY_ALLOW_CASCADE_DESTRUCTIVE not set"
   run rpc_result package.install "{\"id\":\"immich\",\"dockerImage\":\"${IMMICH_IMAGE}\"}"
   [ "$status" -eq 0 ]
   run wait_for_container_status immich running 180
   [ "$status" -eq 0 ]
-  run wait_for_container_status immich-postgres running 120
-  [ "$status" -eq 0 ]
-  run wait_for_container_status immich-redis running 120
-  [ "$status" -eq 0 ]
 }