lfg2025/archy
1
0
Fork 0
Code Issues 16 Pull Requests Actions Packages Projects Releases 44 Wiki Activity

fix(tests): make required-stack-destructive.bats portable across app rosters

Browse Source 
Same class of bug as required-stack.bats: hardcoded required_containers
included mempool/mempool-api unconditionally, so a node without the
mempool stack (e.g. .5) hard-fails restarting a container that was never
installed, and waits out full 180-240s timeouts probing endpoints that
will never come up. Likely explains .5's abnormally long (2216s) iteration
1 runtime during the current multinode-pass run. Same skip-if-absent fix
as the prior commit.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This commit is contained in:
archipelago 2026-07-01 13:59:06 -04:00
parent f1055164d2
commit daa8fb4891
1 changed files with 39 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
tests/lifecycle/bats/required-stack-destructive.bats
View File

@ -12,6 +12,20 @@ required_containers=(
"mempool-api" "mempool-api"
) )
container_installed() {
podman ps -a --format '{{.Names}}' | grep -Fx "$1" >/dev/null
}
# Only the subset of required_containers actually installed on this node —
# a node without the mempool stack (or another optional app) shouldn't
# hard-fail restarting/probing something it was never meant to have.
installed_required_containers() {
local c
for c in "${required_containers[@]}"; do
container_installed "$c" && echo "$c"
done
}
wait_running() { wait_running() {
local name="$1" local name="$1"
local timeout="${2:-120}" local timeout="${2:-120}"
@ -60,19 +74,23 @@ restart_with_retry() {
@test "restart each required service container and verify it recovers" { @test "restart each required service container and verify it recovers" {
[[ "${ARCHY_ALLOW_DESTRUCTIVE:-0}" == "1" ]] || skip "ARCHY_ALLOW_DESTRUCTIVE not set" [[ "${ARCHY_ALLOW_DESTRUCTIVE:-0}" == "1" ]] || skip "ARCHY_ALLOW_DESTRUCTIVE not set"
for c in "${required_containers[@]}"; do local targets; targets="$(installed_required_containers)"
[[ -n "$targets" ]] || skip "none of required_containers installed on this node"
while IFS= read -r c; do
run restart_with_retry "$c" 4 run restart_with_retry "$c" 4
[ "$status" -eq 0 ] [ "$status" -eq 0 ]
run wait_running "$c" 180 run wait_running "$c" 180
[ "$status" -eq 0 ] [ "$status" -eq 0 ]
done done <<< "$targets"
} }
@test "required endpoints still respond after restarts" { @test "required endpoints still respond after restarts" {
[[ "${ARCHY_ALLOW_DESTRUCTIVE:-0}" == "1" ]] || skip "ARCHY_ALLOW_DESTRUCTIVE not set" [[ "${ARCHY_ALLOW_DESTRUCTIVE:-0}" == "1" ]] || skip "ARCHY_ALLOW_DESTRUCTIVE not set"
if container_installed archy-bitcoin-ui; then
run wait_http_ok "http://127.0.0.1:8334/" 180 run wait_http_ok "http://127.0.0.1:8334/" 180
[ "$status" -eq 0 ] [ "$status" -eq 0 ]
fi
# :8081 is nginx-proxy-manager — an OPTIONAL app (not in required_containers). # :8081 is nginx-proxy-manager — an OPTIONAL app (not in required_containers).
# Only assert it when NPM is actually installed on this node; otherwise the # Only assert it when NPM is actually installed on this node; otherwise the
@ -82,12 +100,17 @@ restart_with_retry() {
[ "$status" -eq 0 ] [ "$status" -eq 0 ]
fi fi
if container_installed mempool; then
run wait_http_ok "http://127.0.0.1:4080/" 180 run wait_http_ok "http://127.0.0.1:4080/" 180
[ "$status" -eq 0 ] [ "$status" -eq 0 ]
fi
if container_installed mempool-api; then
run wait_http_ok "http://127.0.0.1:8999/api/v1/backend-info" 240 run wait_http_ok "http://127.0.0.1:8999/api/v1/backend-info" 240
[ "$status" -eq 0 ] [ "$status" -eq 0 ]
fi
if container_installed lnd; then
# lnd RPC readiness lags container 'running' (wallet unlock + graph sync) — # lnd RPC readiness lags container 'running' (wallet unlock + graph sync) —
# retry rather than single-shot. See lnd.bats. # retry rather than single-shot. See lnd.bats.
run sh -lc 'for i in $(seq 1 60); do run sh -lc 'for i in $(seq 1 60); do
@ -95,4 +118,5 @@ restart_with_retry() {
sleep 3 sleep 3
done; exit 1' done; exit 1'
[ "$status" -eq 0 ] [ "$status" -eq 0 ]
fi
} }