lfg2025/archy
1
0
Fork 0
Code Issues 9 Pull Requests Actions Packages Projects Releases 44 Wiki Activity

[Bug]: Strange peer request behaviour #1

New Issue
Closed
opened 2026-05-17 14:12:17 +00:00 by ssmithx · 1 comment
ssmithx commented 2026-05-17 14:12:17 +00:00
Copy Link

Description

Pending peer request shows up again after being signed

Steps to Reproduce

Search for nodes:
Request a connection.
On the other node, refresh "Pending peer requests"
You should see the incoming request. Click approve and then click Poll Now. You will see the approved request plus a new pending one. Can be repeated

Expected Behavior

It should only show the approved request

Actual Behavior

image.png

Archipelago Version

1.7.56

Hardware

x86_64 (Intel/AMD)

Relevant Logs

No response

Screenshots

No response

### Description Pending peer request shows up again after being signed ### Steps to Reproduce Search for nodes: Request a connection. On the other node, refresh "Pending peer requests" You should see the incoming request. Click approve and then click Poll Now. You will see the approved request plus a new pending one. Can be repeated ### Expected Behavior It should only show the approved request ### Actual Behavior ![image.png](/attachments/e4c8da54-2133-4c36-a00c-7cff2b1f9f6f) ### Archipelago Version 1.7.56 ### Hardware x86_64 (Intel/AMD) ### Relevant Logs _No response_ ### Screenshots _No response_
image.png
837 KiB
ssmithx changed title from [Bug]: to [Bug]: Strange peer request behaviour 2026-05-18 00:11:26 +00:00
lfg2025 commented 2026-06-17 16:38:50 +00:00
Owner
Copy Link

Fixed: the inbound-request dedup now rejects re-syncs for peers that are already Pending OR Approved (core/archipelago/src/federation/pending.rs — insert_inbound), so approving + Poll Now no longer spawns a fresh pending row. Rejected is intentionally left out so a rejected peer can ask again. Added regression test test_approved_request_does_not_respawn_pending (passing). Closing.

Fixed: the inbound-request dedup now rejects re-syncs for peers that are already `Pending` OR `Approved` (`core/archipelago/src/federation/pending.rs` — `insert_inbound`), so approving + Poll Now no longer spawns a fresh pending row. `Rejected` is intentionally left out so a rejected peer can ask again. Added regression test `test_approved_request_does_not_respawn_pending` (passing). Closing.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
lfg2025
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: lfg2025/archy#1
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?