Fix/bitcoin core tor service name #158

2026-09-10T16:35:12Z

ssmithx commented

2026-09-10 16:35:12 +00:00

Summary

Verification

Checklist

Rust formatting/clippy/tests pass when backend code changed.
Frontend type-check/build/tests pass when frontend code changed.
App manifests validate when app packaging changed.
Generated catalogs are updated when manifest-owned catalog fields changed.
Docs are updated for user-facing or developer-facing behavior changes.
No secrets, generated build outputs, local screenshots, or private host details are included.

## Summary  ## Verification  ## Checklist - [ ] Rust formatting/clippy/tests pass when backend code changed. - [ ] Frontend type-check/build/tests pass when frontend code changed. - [ ] App manifests validate when app packaging changed. - [ ] Generated catalogs are updated when manifest-owned catalog fields changed. - [ ] Docs are updated for user-facing or developer-facing behavior changes. - [ ] No secrets, generated build outputs, local screenshots, or private host details are included.

ssmithx added 2 commits 2026-09-10 16:35:13 +00:00

fix(tor): recognize bitcoin-core in Tor auto-enrollment tables 69f3a355c7

apps/bitcoin-core/manifest.yml uses id "bitcoin-core", but
known_service_port/is_protocol_service (tor/mod.rs) and
tor_service_name (docker_packages.rs) only matched "bitcoin" and
"bitcoin-knots", so the app silently never got auto-enrolled for a
P2P (8333) hidden service at install time, and the UI's Tor address
lookup for it always returned None.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WxfWiFfnBkdSxwKUuV2tNy

fix(tor): un-alias bitcoin-core's hidden-service name; add regression tests dc7b598558

read_tor_address("bitcoin-core") was resolving through tor_service_name to
the shared "bitcoin" alias, but enrollment (install.rs auto-enroll and the
tor.create-service RPC) always names HiddenServiceDir/tor-hostnames entries
using the raw package_id verbatim — never canonicalized. On a real node
that's hidden_service_bitcoin-core, which the aliased lookup never found,
so the per-app UI Tor badge stayed empty even after the previous commit
made bitcoin-core auto-enrollable.

Give bitcoin-core its own identity-mapped arm instead of folding it into
the legacy bitcoin/bitcoin-knots/bitcoind alias, and pin all three lookup
tables (known_service_port, is_protocol_service, tor_service_name) with
regression tests so this alias-drift class of bug can't recur silently.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WxfWiFfnBkdSxwKUuV2tNy

chaum commented

2026-09-12 14:19:22 +00:00

Maintainer review: cargo fmt --all -- --check passes. Targeted regression tests for the Bitcoin Core Tor protocol-service port and self hidden-service mapping both pass. The change is focused and mergeable from the code-review side; we will keep it open until the remaining PR review batch and node-level restart/regeneration check are complete.

Maintainer review: `cargo fmt --all -- --check` passes. Targeted regression tests for the Bitcoin Core Tor protocol-service port and self hidden-service mapping both pass. The change is focused and mergeable from the code-review side; we will keep it open until the remaining PR review batch and node-level restart/regeneration check are complete.

chaum referenced this issue from a commit

2026-09-13 05:37:18 +00:00

Merge PR #158: preserve Bitcoin Core Tor service naming

chaum closed this pull request

2026-09-13 10:12:45 +00:00

Pull request closed

Please reopen this pull request to perform a merge.

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: lfg2025/archy#158