1e283daf13
Container recovery: - Health monitor: MAX_RESTART_ATTEMPTS 3→10, interval 60s→120s - Dependency-aware restarts: won't restart services before their deps - Reset dependent counters when a dependency recovers - Handle "created" state containers (were invisible to health monitor) - Added IndeedHub, mempool-api, mysql to tier system - Crash recovery: podman start timeout 30s→120s with retry - Podman client: socket timeout 5s→30s, added restart policy UI state representation: - Exit code 0 shows "stopped" (gray), not "crashed" (red) - Exit code 137 shows "killed (OOM)" - Non-zero exit shows "crashed" (red) - Added exit_code field to PackageDataEntry Install/uninstall fixes: - Install returns error when container doesn't start (was silent success) - Post-install hooks awaited instead of fire-and-forget tokio::spawn - Uninstall: graceful rm before force, volume prune, network cleanup - Uninstall returns error on partial failure (was 200 OK) Config consistency: - DB passwords read from /var/lib/archipelago/secrets/ (was hardcoded) - Bitcoin: added ZMQ ports 28332/28333 for LND block notifications - IndeedHub port 7777→8190 (was conflicting with strfry) - Marketplace versions: LND 0.17.4→0.18.4, Mempool 2.5.0→3.0.0 Performance: - Metrics collector interval 60s→300s (was duplicating health monitor) - Podman client: proper error propagation instead of unwrap_or_default Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
28 lines
968 B
Markdown
28 lines
968 B
Markdown
# Polish: Backend Quality
|
|
|
|
All changes built on dev server, not macOS: `./scripts/deploy-to-target.sh --live`
|
|
|
|
## Priority 1: Eliminate panics
|
|
```bash
|
|
ssh archipelago@192.168.1.228 "grep -rn 'unwrap()\|\.expect(' ~/archy/core/archipelago/src/ --include='*.rs' | grep -v test | grep -v '_test.rs'"
|
|
```
|
|
Replace with `?` + `.context()` or `.map_err()`.
|
|
|
|
## Priority 2: Add timeouts
|
|
- Container ops: `tokio::time::timeout(Duration::from_secs(30), op).await`
|
|
- HTTP/RPC calls: `reqwest::Client::builder().timeout(Duration::from_secs(10))`
|
|
|
|
## Priority 3: Connection pooling
|
|
Store reusable `reqwest::Client` in RpcHandler instead of creating per-request.
|
|
|
|
## Priority 4: Clippy
|
|
```bash
|
|
ssh archipelago@192.168.1.228 "cd ~/archy && cargo clippy --all-targets --all-features 2>&1"
|
|
```
|
|
|
|
## Priority 5: Replace println with tracing
|
|
`println!` → `tracing::info!`, `eprintln!` → `tracing::warn!`
|
|
|
|
## Verify
|
|
Zero clippy warnings, zero unwrap/expect in prod code, zero println.
|