- Fix .198-style fresh installs: systemd service ExecStartPre creates /run/user/1000, enable podman.socket, chmod 644 /etc/hosts - Filebrowser: add /data volume for database (fixes read-only crash), secure auth with random password via backend RPC (no more admin/admin) - AppCard: enrich installing state with marketplace metadata (icon, title, description, tier badge, author, version) - Registry: btcpayserver 1.13.5 → 1.13.7, images mirrored - ReadWritePaths: add home container paths for rootless podman Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
330 lines
11 KiB
TypeScript
330 lines
11 KiB
TypeScript
import { describe, it, expect, vi, beforeEach } from 'vitest'
|
|
import { sanitizePath } from '../filebrowser-client'
|
|
|
|
const mockFetch = vi.fn()
|
|
vi.stubGlobal('fetch', mockFetch)
|
|
|
|
// FileBrowserClient reads window.location.origin in constructor, so stub it
|
|
Object.defineProperty(window, 'location', {
|
|
value: { origin: 'http://localhost', protocol: 'http:', hostname: 'localhost' },
|
|
writable: true,
|
|
})
|
|
|
|
// Import after stubs
|
|
const { fileBrowserClient } = await import('../filebrowser-client')
|
|
|
|
function jsonResponse(body: unknown, status = 200): Response {
|
|
return {
|
|
ok: status >= 200 && status < 300,
|
|
status,
|
|
statusText: status === 200 ? 'OK' : 'Error',
|
|
json: () => Promise.resolve(body),
|
|
text: () => Promise.resolve(typeof body === 'string' ? body : JSON.stringify(body)),
|
|
blob: () => Promise.resolve(new Blob([JSON.stringify(body)])),
|
|
headers: new Headers(),
|
|
redirected: false,
|
|
type: 'basic' as ResponseType,
|
|
url: '',
|
|
clone: () => jsonResponse(body, status),
|
|
body: null,
|
|
bodyUsed: false,
|
|
arrayBuffer: () => Promise.resolve(new ArrayBuffer(0)),
|
|
formData: () => Promise.resolve(new FormData()),
|
|
bytes: () => Promise.resolve(new Uint8Array()),
|
|
}
|
|
}
|
|
|
|
describe('FileBrowserClient', () => {
|
|
beforeEach(() => {
|
|
mockFetch.mockReset()
|
|
})
|
|
|
|
describe('login', () => {
|
|
it('authenticates via backend RPC and stores token', async () => {
|
|
mockFetch.mockResolvedValueOnce(jsonResponse({ result: { token: 'jwt-token-123' } }))
|
|
|
|
const result = await fileBrowserClient.login()
|
|
|
|
expect(result).toBe(true)
|
|
expect(fileBrowserClient.isAuthenticated).toBe(true)
|
|
expect(mockFetch).toHaveBeenCalledWith(
|
|
'/rpc/v1',
|
|
expect.objectContaining({
|
|
method: 'POST',
|
|
body: JSON.stringify({ method: 'app.filebrowser-token' }),
|
|
}),
|
|
)
|
|
})
|
|
|
|
it('returns false on failed login', async () => {
|
|
mockFetch.mockResolvedValueOnce(jsonResponse(null, 403))
|
|
|
|
const result = await fileBrowserClient.login()
|
|
|
|
expect(result).toBe(false)
|
|
})
|
|
|
|
it('returns false on network error', async () => {
|
|
mockFetch.mockRejectedValueOnce(new Error('Network error'))
|
|
|
|
const result = await fileBrowserClient.login()
|
|
|
|
expect(result).toBe(false)
|
|
})
|
|
})
|
|
|
|
describe('listDirectory', () => {
|
|
it('lists items in a directory', async () => {
|
|
// Ensure authenticated first
|
|
mockFetch.mockResolvedValueOnce(jsonResponse('"token"'))
|
|
await fileBrowserClient.login()
|
|
|
|
const mockItems = {
|
|
items: [
|
|
{ name: 'photos', path: '/photos', size: 0, modified: '2026-01-01', isDir: true, type: '', extension: '' },
|
|
{ name: 'readme.txt', path: '/readme.txt', size: 1024, modified: '2026-01-01', isDir: false, type: '', extension: 'txt' },
|
|
],
|
|
numDirs: 1,
|
|
numFiles: 1,
|
|
sorting: { by: 'name', asc: true },
|
|
}
|
|
mockFetch.mockResolvedValueOnce(jsonResponse(mockItems))
|
|
|
|
const items = await fileBrowserClient.listDirectory('/')
|
|
|
|
expect(items).toHaveLength(2)
|
|
expect(items[0]!.name).toBe('photos')
|
|
expect(items[1]!.extension).toBe('txt')
|
|
})
|
|
|
|
it('adds leading slash if missing', async () => {
|
|
mockFetch.mockResolvedValueOnce(jsonResponse('"token"'))
|
|
await fileBrowserClient.login()
|
|
|
|
mockFetch.mockResolvedValueOnce(jsonResponse({ items: [], numDirs: 0, numFiles: 0, sorting: { by: 'name', asc: true } }))
|
|
|
|
await fileBrowserClient.listDirectory('photos')
|
|
|
|
const [url] = mockFetch.mock.calls[mockFetch.mock.calls.length - 1]!
|
|
expect(url).toContain('/api/resources/photos')
|
|
})
|
|
|
|
it('throws on non-OK response', async () => {
|
|
mockFetch.mockResolvedValueOnce(jsonResponse('"token"'))
|
|
await fileBrowserClient.login()
|
|
|
|
mockFetch.mockResolvedValueOnce(jsonResponse(null, 404))
|
|
|
|
await expect(fileBrowserClient.listDirectory('/missing')).rejects.toThrow('Failed to list directory: 404')
|
|
})
|
|
})
|
|
|
|
describe('downloadUrl', () => {
|
|
it('constructs download URL for file path', async () => {
|
|
const url = fileBrowserClient.downloadUrl('/photos/sunset.jpg')
|
|
|
|
expect(url).toContain('/api/raw/photos/sunset.jpg')
|
|
})
|
|
|
|
it('adds leading slash if missing', async () => {
|
|
const url = fileBrowserClient.downloadUrl('file.txt')
|
|
|
|
expect(url).toContain('/api/raw/file.txt')
|
|
})
|
|
})
|
|
|
|
describe('upload', () => {
|
|
it('uploads a file to the correct path', async () => {
|
|
mockFetch.mockResolvedValueOnce(jsonResponse('"token"'))
|
|
await fileBrowserClient.login()
|
|
|
|
mockFetch.mockResolvedValueOnce(jsonResponse(null, 200))
|
|
const file = new File(['hello'], 'test.txt', { type: 'text/plain' })
|
|
|
|
await fileBrowserClient.upload('/documents', file)
|
|
|
|
const [url, init] = mockFetch.mock.calls[mockFetch.mock.calls.length - 1]!
|
|
expect(url).toContain('/api/resources/documents/test.txt')
|
|
expect(url).toContain('override=true')
|
|
expect(init.method).toBe('POST')
|
|
expect(init.body).toBe(file)
|
|
})
|
|
|
|
it('throws on upload failure', async () => {
|
|
mockFetch.mockResolvedValueOnce(jsonResponse('"token"'))
|
|
await fileBrowserClient.login()
|
|
|
|
mockFetch.mockResolvedValueOnce(jsonResponse('Disk full', 507))
|
|
const file = new File(['data'], 'big.bin')
|
|
|
|
await expect(fileBrowserClient.upload('/', file)).rejects.toThrow('Upload failed (507)')
|
|
})
|
|
})
|
|
|
|
describe('createFolder', () => {
|
|
it('creates a folder at the correct path', async () => {
|
|
mockFetch.mockResolvedValueOnce(jsonResponse('"token"'))
|
|
await fileBrowserClient.login()
|
|
|
|
mockFetch.mockResolvedValueOnce(jsonResponse(null, 200))
|
|
|
|
await fileBrowserClient.createFolder('/documents', 'photos')
|
|
|
|
const [url, init] = mockFetch.mock.calls[mockFetch.mock.calls.length - 1]!
|
|
expect(url).toContain('/api/resources/documents/photos/')
|
|
expect(init.method).toBe('POST')
|
|
})
|
|
|
|
it('throws on failure', async () => {
|
|
mockFetch.mockResolvedValueOnce(jsonResponse('"token"'))
|
|
await fileBrowserClient.login()
|
|
|
|
mockFetch.mockResolvedValueOnce(jsonResponse(null, 500))
|
|
|
|
await expect(fileBrowserClient.createFolder('/', 'test')).rejects.toThrow('Create folder failed: 500')
|
|
})
|
|
})
|
|
|
|
describe('deleteItem', () => {
|
|
it('sends DELETE request for the item', async () => {
|
|
mockFetch.mockResolvedValueOnce(jsonResponse('"token"'))
|
|
await fileBrowserClient.login()
|
|
|
|
mockFetch.mockResolvedValueOnce(jsonResponse(null, 200))
|
|
|
|
await fileBrowserClient.deleteItem('/photos/old.jpg')
|
|
|
|
const [url, init] = mockFetch.mock.calls[mockFetch.mock.calls.length - 1]!
|
|
expect(url).toContain('/api/resources/photos/old.jpg')
|
|
expect(init.method).toBe('DELETE')
|
|
})
|
|
|
|
it('throws on failure', async () => {
|
|
mockFetch.mockResolvedValueOnce(jsonResponse('"token"'))
|
|
await fileBrowserClient.login()
|
|
|
|
mockFetch.mockResolvedValueOnce(jsonResponse(null, 403))
|
|
|
|
await expect(fileBrowserClient.deleteItem('/protected')).rejects.toThrow('Delete failed: 403')
|
|
})
|
|
})
|
|
|
|
describe('getUsage', () => {
|
|
it('returns usage summary for root directory', async () => {
|
|
// Login first
|
|
mockFetch.mockResolvedValueOnce(jsonResponse('"token"'))
|
|
await fileBrowserClient.login()
|
|
|
|
const mockData = {
|
|
items: [
|
|
{ name: 'photos', path: '/photos', size: 0, modified: '2026-01-01', isDir: true, type: '', extension: '' },
|
|
{ name: 'file1.txt', path: '/file1.txt', size: 500, modified: '2026-01-01', isDir: false, type: '', extension: 'txt' },
|
|
{ name: 'file2.jpg', path: '/file2.jpg', size: 1500, modified: '2026-01-01', isDir: false, type: '', extension: 'jpg' },
|
|
],
|
|
numDirs: 1,
|
|
numFiles: 2,
|
|
sorting: { by: 'name', asc: true },
|
|
}
|
|
mockFetch.mockResolvedValueOnce(jsonResponse(mockData))
|
|
|
|
const usage = await fileBrowserClient.getUsage()
|
|
|
|
expect(usage.totalSize).toBe(2000)
|
|
expect(usage.folderCount).toBe(1)
|
|
expect(usage.fileCount).toBe(2)
|
|
})
|
|
|
|
it('returns zeros on failed request', async () => {
|
|
mockFetch.mockResolvedValueOnce(jsonResponse('"token"'))
|
|
await fileBrowserClient.login()
|
|
|
|
mockFetch.mockResolvedValueOnce(jsonResponse(null, 500))
|
|
|
|
const usage = await fileBrowserClient.getUsage()
|
|
|
|
expect(usage).toEqual({ totalSize: 0, folderCount: 0, fileCount: 0 })
|
|
})
|
|
})
|
|
|
|
describe('isTextFile', () => {
|
|
it('identifies text file extensions', () => {
|
|
expect(fileBrowserClient.isTextFile('readme.md')).toBe(true)
|
|
expect(fileBrowserClient.isTextFile('config.json')).toBe(true)
|
|
expect(fileBrowserClient.isTextFile('script.py')).toBe(true)
|
|
expect(fileBrowserClient.isTextFile('main.rs')).toBe(true)
|
|
expect(fileBrowserClient.isTextFile('style.css')).toBe(true)
|
|
})
|
|
|
|
it('returns false for binary files', () => {
|
|
expect(fileBrowserClient.isTextFile('photo.jpg')).toBe(false)
|
|
expect(fileBrowserClient.isTextFile('video.mp4')).toBe(false)
|
|
expect(fileBrowserClient.isTextFile('archive.zip')).toBe(false)
|
|
})
|
|
})
|
|
|
|
describe('rename', () => {
|
|
it('sends PATCH request with new destination', async () => {
|
|
mockFetch.mockResolvedValueOnce(jsonResponse('"token"'))
|
|
await fileBrowserClient.login()
|
|
|
|
mockFetch.mockResolvedValueOnce(jsonResponse(null, 200))
|
|
|
|
await fileBrowserClient.rename('/photos/old.jpg', 'new.jpg')
|
|
|
|
const [url, init] = mockFetch.mock.calls[mockFetch.mock.calls.length - 1]!
|
|
expect(url).toContain('/api/resources/photos/old.jpg')
|
|
expect(init.method).toBe('PATCH')
|
|
expect(JSON.parse(init.body)).toEqual({ destination: '/photos/new.jpg' })
|
|
})
|
|
|
|
it('throws on rename failure', async () => {
|
|
mockFetch.mockResolvedValueOnce(jsonResponse('"token"'))
|
|
await fileBrowserClient.login()
|
|
|
|
mockFetch.mockResolvedValueOnce(jsonResponse(null, 409))
|
|
|
|
await expect(fileBrowserClient.rename('/a.txt', 'b.txt')).rejects.toThrow('Rename failed: 409')
|
|
})
|
|
})
|
|
})
|
|
|
|
describe('sanitizePath', () => {
|
|
it('returns / for empty path', () => {
|
|
expect(sanitizePath('')).toBe('/')
|
|
})
|
|
|
|
it('preserves simple paths', () => {
|
|
expect(sanitizePath('/photos')).toBe('/photos')
|
|
expect(sanitizePath('/docs/readme.md')).toBe('/docs/readme.md')
|
|
})
|
|
|
|
it('adds leading slash', () => {
|
|
expect(sanitizePath('photos/image.jpg')).toBe('/photos/image.jpg')
|
|
})
|
|
|
|
it('resolves . segments', () => {
|
|
expect(sanitizePath('/photos/./image.jpg')).toBe('/photos/image.jpg')
|
|
})
|
|
|
|
it('resolves .. segments', () => {
|
|
expect(sanitizePath('/photos/../etc/passwd')).toBe('/etc/passwd')
|
|
})
|
|
|
|
it('prevents traversal past root', () => {
|
|
expect(sanitizePath('/../../../etc/passwd')).toBe('/etc/passwd')
|
|
expect(sanitizePath('/../../..')).toBe('/')
|
|
})
|
|
|
|
it('handles multiple consecutive .. at root', () => {
|
|
expect(sanitizePath('/../../../etc/shadow')).toBe('/etc/shadow')
|
|
})
|
|
|
|
it('handles mixed . and .. segments', () => {
|
|
expect(sanitizePath('/a/./b/../c')).toBe('/a/c')
|
|
})
|
|
|
|
it('removes trailing slashes in segments', () => {
|
|
expect(sanitizePath('/photos//image.jpg')).toBe('/photos/image.jpg')
|
|
})
|
|
})
|