ssmithx
c692a8b52f
Confirmed on the just-packaged binary: `archy-rnodeconf --info` printed everything correctly, then crashed with NameError: name 'exit' is not defined and returned exit code 1. rnodeconf.py's own graceful_exit() calls the bare exit() builtin, which is only ever defined by site.py for interactive Python — a frozen PyInstaller app skips that init, so any bundled script relying on it hits this the moment it tries to quit cleanly, after the real work already succeeded. Classic, well-documented PyInstaller gotcha; the standard fix is a runtime hook pre-defining exit/quit as sys.exit before the bundled script's own code runs. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
19 lines
831 B
Python
19 lines
831 B
Python
# PyInstaller runtime hook — see build.sh.
|
|
#
|
|
# `exit()`/`quit()` aren't part of the language; they're `site.Quitter`
|
|
# instances the interactive interpreter injects into builtins at startup
|
|
# (site.py). A frozen PyInstaller app never runs that interactive-mode
|
|
# init, so any bundled script that calls bare `exit()` (RNS's own
|
|
# rnodeconf.py does, in its graceful_exit() cleanup path) hits
|
|
# `NameError: name 'exit' is not defined` right as it tries to quit
|
|
# cleanly — the real work above it already completed, but the process
|
|
# still exits 1, which is a foot-gun for anything scripting off the exit
|
|
# code. Pre-define both as sys.exit so that path is a no-op crash-wise.
|
|
import builtins
|
|
import sys
|
|
|
|
if not hasattr(builtins, "exit"):
|
|
builtins.exit = sys.exit
|
|
if not hasattr(builtins, "quit"):
|
|
builtins.quit = sys.exit
|