lfg2025/botfights
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: only generate MC choices for human fights, not bot-vs-bot

Browse Source 
Bots answer via webhook and don't need multiple choice options.
Add forHuman parameter to pickChallenge, update tests to cover both modes.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Dorian
2026-03-09 09:15:25 +00:00
co-authored by Claude Opus 4.6
parent dcd8570ed8
commit 592841d7b1
2 changed files with 27 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files
server/src/engine/challenges.ts
+14 -14
View File
@@ -70,7 +70,7 @@ export function roundToDifficulty(round: number): PromptDifficulty {
return 'hard'
}
export function pickChallenge(usedTypes: Set<string>, _arenaModifier: string | null, themeBias?: PromptTheme, roundNumber?: number): Challenge {
export function pickChallenge(usedTypes: Set<string>, _arenaModifier: string | null, themeBias?: PromptTheme, roundNumber?: number, forHuman = false): Challenge {
let available = TEMPLATES.filter(t => !usedTypes.has(t.type))
if (available.length === 0) available = TEMPLATES
@@ -88,7 +88,7 @@ export function pickChallenge(usedTypes: Set<string>, _arenaModifier: string | n
const template = pick(pool)
const targetTheme = themeBias || pickTheme()
const targetDifficulty = roundNumber ? roundToDifficulty(roundNumber) : undefined
return templateToChallenge(template, targetTheme, targetDifficulty)
return templateToChallenge(template, targetTheme, targetDifficulty, forHuman)
}
/** Ranked challenge: no multiple choice, only harder creative/open-ended prompts */
@@ -262,7 +262,7 @@ function generateCreativeChoices(type: string): { choices: string[]; answer: str
}
}
function templateToChallenge(template: ChallengeTemplate, targetTheme?: PromptTheme, targetDifficulty?: PromptDifficulty): Challenge {
function templateToChallenge(template: ChallengeTemplate, targetTheme?: PromptTheme, targetDifficulty?: PromptDifficulty, forHuman = false): Challenge {
// Prefer prompts matching target theme if any are tagged
let prompts = template.prompts
if (targetTheme) {
@@ -276,19 +276,19 @@ function templateToChallenge(template: ChallengeTemplate, targetTheme?: PromptTh
}
const entry = pick(prompts)
// Determine choices
// Determine choices — only for human fights (bots answer via webhook)
let choices: string[] | undefined
let answers = entry.answers
if (entry.choices) {
choices = shuffleArray(entry.choices)
} else if (entry.answers?.length === 1 && ['true', 'false'].includes(entry.answers[0].toLowerCase())) {
// Auto-generate True/False choices for boolean questions
choices = shuffleArray(['True', 'False'])
} else if (template.scoring === 'creative' && CREATIVE_CHOICES[template.type]) {
// Auto-generate multiple choice for creative challenges
const generated = generateCreativeChoices(template.type)
choices = generated.choices
answers = [generated.answer]
if (forHuman) {
if (entry.choices) {
choices = shuffleArray(entry.choices)
} else if (entry.answers?.length === 1 && ['true', 'false'].includes(entry.answers[0].toLowerCase())) {
choices = shuffleArray(['True', 'False'])
} else if (template.scoring === 'creative' && CREATIVE_CHOICES[template.type]) {
const generated = generateCreativeChoices(template.type)
choices = generated.choices
answers = [generated.answer]
}
}
// For creative challenges with choices, add a "Pick the best response:" prefix